Refactor and move prepare_input_tensors #1712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1712
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b08d897 with merge base 23aceb8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52645309 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 26, 2024
Summary: This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309
dbort
force-pushed
the
export-D52645309
branch
from
506c05b to
0e586c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52645309 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 26, 2024
Summary: This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309
dbort
force-pushed
the
export-D52645309
branch
from
0e586c9 to
64aa2d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52645309 |
Summary: This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309
dbort
force-pushed
the
export-D52645309
branch
from
64aa2d1 to
956ddb5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52645309 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 26, 2024
Summary: This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Jan 26, 2024
Summary: This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309
dbort
force-pushed
the
export-D52645309
branch
from
956ddb5 to
b08d897
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52645309 |
|
This pull request has been merged in 61bc5d1. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Jan 29, 2024
Summary: Pull Request resolved: pytorch#1712 This new version: - Can fail non-fatally - Uses RAII to clean up the memory - Uses separate files for lean and aten modes - Has tests - Lives somewhere other than util.h Reviewed By: larryliu0820 Differential Revision: D52645309 fbshipit-source-id: b117269046efb137982b214b6877b13376b721db
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This new version:
Differential Revision: D52645309