Skip to content

Conversation

@cymbalrush
Copy link
Contributor

Problem
util::PrepareInputTensors is deprecated and is unavailable when linking to executorch.a. This is causing build failures.

Solution
Remove the util::PrepareInputTensors call and set the method input using a std::vector as the data storage.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1747

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit a594bd6 with merge base 1a58959 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2024
@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor

Let's kick off a test-coreml-delegate job on this PR.

@JacobSzwejbka
Copy link
Contributor

JacobSzwejbka commented Jan 30, 2024

can we just use this #1712

extension/runner_util/inputs.cpp

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified test-coreml-test is fixed with this PR. Thanks!

@cymbalrush
Copy link
Contributor Author

cymbalrush commented Jan 30, 2024

extension/runner_util/inputs.cpp

@JacobSzwejbka I couldn't find a build option in the CMake file to include the extension/runner_util directory there are EXECUTORCH_BUILD_EXTENSION_MODULE and EXECUTORCH_BUILD_EXTENSION_DATA_LOADER options but they include different directories.

I can add EXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL option to include extension/runner_util directory but would like to do it in a following PR.

@facebook-github-bot
Copy link
Contributor

@shoumikhin merged this pull request in 7ba9b0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants