-
Notifications
You must be signed in to change notification settings - Fork 696
Fix build failures #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failures #1747
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1747
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit a594bd6 with merge base 1a58959 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Let's kick off a test-coreml-delegate job on this PR. |
|
can we just use this #1712 extension/runner_util/inputs.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified test-coreml-test is fixed with this PR. Thanks!
@JacobSzwejbka I couldn't find a build option in the CMake file to include the I can add |
|
@shoumikhin merged this pull request in 7ba9b0d. |
Problem
util::PrepareInputTensorsis deprecated and is unavailable when linking toexecutorch.a. This is causing build failures.Solution
Remove the
util::PrepareInputTensorscall and set the method input using astd::vectoras the data storage.