Skip to content

Fix android build#17126

Merged
kirklandsign merged 2 commits intomainfrom
android-fix
Feb 3, 2026
Merged

Fix android build#17126
kirklandsign merged 2 commits intomainfrom
android-fix

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

Summary

Fix android build

Test plan

CI

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17126

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

As of commit dc76815 with merge base 409257f (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review February 2, 2026 23:54
Copilot AI review requested due to automatic review settings February 2, 2026 23:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an Android build break in the Java LLM wrapper by updating a generate(...) overload to call the correct native method signature.

Changes:

  • Update generate(String, int, LlmCallback, boolean) to pass default BOS/EOS arguments so it matches the 7-parameter native generate(...) signature.
  • Minor formatting adjustment to the initHybrid(...) call assignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kirklandsign kirklandsign merged commit 059c729 into main Feb 3, 2026
179 of 183 checks passed
@kirklandsign kirklandsign deleted the android-fix branch February 3, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants