Fix android build#17126
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17126
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Pending, 1 Unrelated FailureAs of commit dc76815 with merge base 409257f ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Fixes an Android build break in the Java LLM wrapper by updating a generate(...) overload to call the correct native method signature.
Changes:
- Update
generate(String, int, LlmCallback, boolean)to pass default BOS/EOS arguments so it matches the 7-parameter nativegenerate(...)signature. - Minor formatting adjustment to the
initHybrid(...)call assignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Fix android build
Test plan
CI