Fix quantized_w8a32_conv1d fusion and operator #17290
Merged
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Python fusion pass (fusion_pass.py): The permute nodes created in
get_args_and_kwargs_mixed_w8a32_conv were missing val metadata, causing
SpecViolationError during ExportedProgram validation. Added val computation
using fake_mode, matching the pattern used by AddmmPattern.
C++ operators (generic + HiFi): cnn_step was called once with wrong
dimensions (input length instead of kernel_size for d1), only producing
out_channels values instead of the full output. Fixed to loop over output
time steps, calling cnn_step per position with correct kernel_size, then
scattering to NCL output layout.
Differential Revision: D92565258