Skip to content

[ET-VK] Add supports_highdim field to OpFeatures#17337

Merged
meta-codesync[bot] merged 1 commit intogh/SS-JIA/415/basefrom
gh/SS-JIA/415/head
Feb 10, 2026
Merged

[ET-VK] Add supports_highdim field to OpFeatures#17337
meta-codesync[bot] merged 1 commit intogh/SS-JIA/415/basefrom
gh/SS-JIA/415/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Feb 10, 2026

Stack from ghstack (oldest at bottom):

Add a supports_highdim boolean field to OpFeatures in the Vulkan delegate op registry. This field indicates whether an operator implementation supports tensors with more than 4 dimensions. It defaults to False, meaning operators will reject high-dimensional tensors during partitioning unless explicitly opted in.

The partitioner now checks all input and output tensors of an op node for >4 dimensions via the new op_contains_high_dim_tensor utility, and skips nodes where the operator has not declared high-dim support.

Operators whose buffer-path shaders use BufferMetadata (which provides dynamic tensor indexing for arbitrary dimensionality) are marked with supports_highdim=True: binary ops, binary scalar (pow), reduce, argreduce, rotary embedding, permute_copy, view_copy, _to_dim_order_copy, squeeze_copy, unsqueeze_copy, gather, expand_copy, select_copy, slice_copy, and split_with_sizes_copy.

Differential Revision: D92740294

Add a `supports_highdim` boolean field to `OpFeatures` in the Vulkan delegate op registry. This field indicates whether an operator implementation supports tensors with more than 4 dimensions. It defaults to `False`, meaning operators will reject high-dimensional tensors during partitioning unless explicitly opted in.

The partitioner now checks all input and output tensors of an op node for >4 dimensions via the new `op_contains_high_dim_tensor` utility, and skips nodes where the operator has not declared high-dim support.

Operators whose buffer-path shaders use `BufferMetadata` (which provides dynamic tensor indexing for arbitrary dimensionality) are marked with `supports_highdim=True`: binary ops, binary scalar (pow), reduce, argreduce, rotary embedding, permute_copy, view_copy, _to_dim_order_copy, squeeze_copy, unsqueeze_copy, gather, expand_copy, select_copy, slice_copy, and split_with_sizes_copy.

Differential Revision: [D92740294](https://our.internmc.facebook.com/intern/diff/D92740294/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17337

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit be18a54 with merge base ba89c69 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2026
SS-JIA pushed a commit that referenced this pull request Feb 10, 2026
Add a `supports_highdim` boolean field to `OpFeatures` in the Vulkan delegate op registry. This field indicates whether an operator implementation supports tensors with more than 4 dimensions. It defaults to `False`, meaning operators will reject high-dimensional tensors during partitioning unless explicitly opted in.

The partitioner now checks all input and output tensors of an op node for >4 dimensions via the new `op_contains_high_dim_tensor` utility, and skips nodes where the operator has not declared high-dim support.

Operators whose buffer-path shaders use `BufferMetadata` (which provides dynamic tensor indexing for arbitrary dimensionality) are marked with `supports_highdim=True`: binary ops, binary scalar (pow), reduce, argreduce, rotary embedding, permute_copy, view_copy, _to_dim_order_copy, squeeze_copy, unsqueeze_copy, gather, expand_copy, select_copy, slice_copy, and split_with_sizes_copy.

Differential Revision: [D92740294](https://our.internmc.facebook.com/intern/diff/D92740294/)

ghstack-source-id: 339885887
Pull Request resolved: #17337
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit 4e38714 into gh/SS-JIA/415/base Feb 10, 2026
180 of 205 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/415/head branch February 10, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants