Skip to content

Migrate quantized_conv2d tests to graph builder#17451

Merged
meta-codesync[bot] merged 1 commit intomainfrom
export-D93112638
Feb 14, 2026
Merged

Migrate quantized_conv2d tests to graph builder#17451
meta-codesync[bot] merged 1 commit intomainfrom
export-D93112638

Conversation

@mcremon-meta
Copy link
Contributor

Summary: As titled. Much easier to debug that way.

Differential Revision: D93112638

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17451

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0cca266 with merge base 6e31609 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Feb 13, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93112638.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

As titled. Much easier to debug that way. Retains the initial tests, adds a few more for 1D cases (will migrate to true 1D kernels soon).

We also update the nchw ops to handle `uint8_t` (that got lost in translation when splitting the ops probably).

Differential Revision: D93112638
facebook-github-bot pushed a commit that referenced this pull request Feb 13, 2026
Summary:

As titled. Much easier to debug that way. Retains the initial tests, adds a few more for 1D cases (will migrate to true 1D kernels soon).

We also update the nchw ops to handle `uint8_t` (that got lost in translation when splitting the ops probably).

Reviewed By: DrJessop

Differential Revision: D93112638
facebook-github-bot pushed a commit that referenced this pull request Feb 13, 2026
Summary:

As titled. Much easier to debug that way. Retains the initial tests, adds a few more for 1D cases (will migrate to true 1D kernels soon).

We also update the nchw ops to handle `uint8_t` (that got lost in translation when splitting the ops probably).

Reviewed By: DrJessop

Differential Revision: D93112638
facebook-github-bot pushed a commit that referenced this pull request Feb 13, 2026
Summary:

As titled. Much easier to debug that way. Retains the initial tests, adds a few more for 1D cases (will migrate to true 1D kernels soon).

We also update the nchw ops to handle `uint8_t` (that got lost in translation when splitting the ops probably).

Reviewed By: DrJessop

Differential Revision: D93112638
@meta-codesync meta-codesync bot merged commit 8ab65b3 into main Feb 14, 2026
195 of 198 checks passed
@meta-codesync meta-codesync bot deleted the export-D93112638 branch February 14, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants