Conversation
pytorchbot
requested review from
larryliu0820 and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17455
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
added 2 commits
February 13, 2026 12:19
Pull Request resolved: #17228 Specify which method to call in the runner. ghstack-source-id: 340390608 @exported-using-ghexport Differential Revision: [D92225533](https://our.internmc.facebook.com/intern/diff/D92225533/)
Pull Request resolved: #17229 Introduce LoraConfig to hold lora parameters such as: - checkpoint - rank - target_modules (e.g. q_proj, k_proj, v_proj, up_proj, down_proj, gate_proj, o_proj) - lora_alpha LoraConfig validation done post-init. LoraConfig can be created with config.json file. Update cases of export_llama_lib to use LoraConfig instead of adapter_checkpoint and adapter_config. NOTE: we may need to extend this to support more customizable features like lora config per layer etc. cc @hakanb ghstack-source-id: 340930093 @exported-using-ghexport Differential Revision: [D92304723](https://our.internmc.facebook.com/intern/diff/D92304723/)
lucylq
approved these changes
Feb 13, 2026
Pull Request resolved: #17230 MultimethodLoraConfig; collects together method name and lora config. ghstack-source-id: 341143477 @exported-using-ghexport Differential Revision: [D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/)
lucylq
force-pushed
the
gh/lucylq/133/orig
branch
from
e057f93 to
2ed0f5e
Compare
lucylq
force-pushed
the
gh/lucylq/132/orig
branch
from
86c70a9 to
be0d894
Compare
This PR needs a
|
chizkiyahu
pushed a commit
to chizkiyahu/executorch
that referenced
this pull request
Feb 23, 2026
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#17230 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/133/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/133/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/132/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/133/orig Differential Revision: [D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/) @diff-train-skip-merge --------- Co-authored-by: Github Executorch <github_executorch@arm.com> Co-authored-by: lucylq <lfq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #17230 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/133/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/133/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/132/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/133/orig
Differential Revision: D92315627
@diff-train-skip-merge