Arm backend: Configure logging at runtime in aot_arm_compiler#17485
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17485
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 5bdb2d7 with merge base c7c7c0a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
|
@pytorchbot label "release notes: none" |
There was a problem hiding this comment.
Pull request overview
This PR updates the Arm AOT compiler example script to configure Python logging at runtime (when arguments are parsed) rather than at module import time, preventing earlier imports from pre-configuring the root logger.
Changes:
- Remove module-import-time
logging.basicConfig(...)configuration. - Configure logging inside
get_args()based on--debug, always applying configuration withforce=True.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zingo
left a comment
There was a problem hiding this comment.
OK to merge after Arm tests are fixed/pass This errors are not related to this PR so this PR might need a rebase after fix to get proper testing.
Move logging setup out of module import and into `get_args()`, and always apply it with `force=True`. This prevents prior imports from locking the root logger at a different level. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I50e037a09ae509964229187c603f66c7d44f94bc
9095591 to
5bdb2d7
Compare
|
Failures were unrelated |
Move logging setup out of module import and into
get_args(), and always apply it withforce=True. This prevents prior imports from locking the root logger at a different level.cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai