Skip to content

Arm backend: Configure logging at runtime in aot_arm_compiler#17485

Merged
martinlsm merged 1 commit into
pytorch:mainfrom
martinlsm:marlin-aac-logging
Feb 18, 2026
Merged

Arm backend: Configure logging at runtime in aot_arm_compiler#17485
martinlsm merged 1 commit into
pytorch:mainfrom
martinlsm:marlin-aac-logging

Conversation

@martinlsm
Copy link
Copy Markdown
Collaborator

@martinlsm martinlsm commented Feb 17, 2026

Move logging setup out of module import and into get_args(), and always apply it with force=True. This prevents prior imports from locking the root logger at a different level.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Copilot AI review requested due to automatic review settings February 17, 2026 10:44
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17485

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 5bdb2d7 with merge base c7c7c0a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2026
@martinlsm
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Feb 17, 2026
@martinlsm
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Feb 17, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Arm AOT compiler example script to configure Python logging at runtime (when arguments are parsed) rather than at module import time, preventing earlier imports from pre-configuring the root logger.

Changes:

  • Remove module-import-time logging.basicConfig(...) configuration.
  • Configure logging inside get_args() based on --debug, always applying configuration with force=True.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge after Arm tests are fixed/pass This errors are not related to this PR so this PR might need a rebase after fix to get proper testing.

Move logging setup out of module import and into `get_args()`, and
always apply it with `force=True`. This prevents prior imports from
locking the root logger at a different level.

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: I50e037a09ae509964229187c603f66c7d44f94bc
@martinlsm martinlsm merged commit 4f1e7bd into pytorch:main Feb 18, 2026
308 of 311 checks passed
@martinlsm martinlsm deleted the marlin-aac-logging branch February 18, 2026 12:47
@martinlsm
Copy link
Copy Markdown
Collaborator Author

Failures were unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants