Cortex-M: remove extractScalarToInt helpers, use static_cast directly#17543
Merged
rascani merged 6 commits intopytorch:mainfrom Mar 5, 2026
Merged
Cortex-M: remove extractScalarToInt helpers, use static_cast directly#17543rascani merged 6 commits intopytorch:mainfrom
rascani merged 6 commits intopytorch:mainfrom
Conversation
Since pytorch#16322 changed all Scalar parameters to int64_t, the extractScalarToInt32 and extractScalarToInt helpers in cortex_m_ops_common.h are unnecessary indirection — they called Scalar::to<int64_t>() then cast, but the values are already int64_t. Replace all call sites with direct static_cast and remove the helpers, the unused Scalar type alias, and the scalar_utils.h include. Also update the quantized_mul Python schema in operators.py to use int instead of Scalar, matching the C++ kernel and operators.yaml. Additionally remove a duplicate kernel_includes.h include from cortex_m_ops_common.h. Co-authored-by: Claude <noreply@anthropic.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17543
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 8 PendingAs of commit 973ae3c with merge base 2cb1ef5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
Contributor
Author
|
Bumping this. |
psiddh
approved these changes
Feb 24, 2026
AdrianLundell
approved these changes
Feb 24, 2026
zingo
added
partner: arm
Contributor
Author
|
Failures unrelated. |
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Mar 17, 2026
…pytorch#17543) ### Summary Since pytorch#16322 changed all Scalar parameters to int64_t, the extractScalarToInt32 and extractScalarToInt helpers in cortex_m_ops_common.h are unnecessary indirection — they called Scalar::to<int64_t>() then cast, but the values are already int64_t. Replace all call sites with direct static_cast and remove the helpers, the unused Scalar type alias, and the scalar_utils.h include. Also update the quantized_mul Python schema in operators.py to use int instead of Scalar, matching the C++ kernel and operators.yaml. Additionally remove a duplicate kernel_includes.h include from cortex_m_ops_common.h. ### Test plan ``` pytest backends/cortex_m/test/ ``` cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @psiddh @AdrianLundell Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #16322 changed all Scalar parameters to int64_t, the extractScalarToInt32 and extractScalarToInt helpers in cortex_m_ops_common.h are unnecessary indirection — they called Scalar::to<int64_t>() then cast, but the values are already int64_t.
Replace all call sites with direct static_cast and remove the helpers, the unused Scalar type alias, and the scalar_utils.h include. Also update the quantized_mul Python schema in operators.py to use int instead of Scalar, matching the C++ kernel and operators.yaml.
Additionally remove a duplicate kernel_includes.h include from cortex_m_ops_common.h.
Test plan
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @psiddh @AdrianLundell