Skip to content

Arm backend: Raise quantization testing thresholds#17617

Merged
AdrianLundell merged 1 commit into
pytorch:mainfrom
AdrianLundell:change-1201121
Feb 23, 2026
Merged

Arm backend: Raise quantization testing thresholds#17617
AdrianLundell merged 1 commit into
pytorch:mainfrom
AdrianLundell:change-1201121

Conversation

@AdrianLundell
Copy link
Copy Markdown
Collaborator

@AdrianLundell AdrianLundell commented Feb 23, 2026

Raises frobenius norm and cosine similarity thresholds for comparison ops and 8aw4 ops. These type of ops will always have potentially large diffs from the original model for random inputs when quantized and they have been causing flaky test failures.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Raises frobenius norm and cosine similarity thresholds
for comparison ops and 8aw4 ops. These type of ops will
always have potentially large diffs from the original model
for random inputs when quantized and they have been causing
flaky test failures.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: Ibdd792b99807c0a256211b3c386df352acecba20
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Feb 23, 2026
@AdrianLundell AdrianLundell added ciflow/trunk release notes: none Do not include this in the release notes labels Feb 23, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17617

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 4 Pending

As of commit 76678cd with merge base 1bc2c4e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2026
@AdrianLundell
Copy link
Copy Markdown
Collaborator Author

Fails unrelated

@AdrianLundell AdrianLundell merged commit 8dc6f36 into pytorch:main Feb 23, 2026
309 of 324 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants