Skip to content

Remove duplicate log.cpp compilation in Android CMakeLists#17634

Merged
kirklandsign merged 1 commit intomainfrom
android/fix-duplicate-log-cpp
Feb 23, 2026
Merged

Remove duplicate log.cpp compilation in Android CMakeLists#17634
kirklandsign merged 1 commit intomainfrom
android/fix-duplicate-log-cpp

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

Summary

jni/log.cpp is already included in the base executorch_jni target (line 76). The training and llama conditional blocks were adding it again via target_sources, causing it to be compiled up to 3 times into the same shared library.

Test plan

CI

jni/log.cpp is already included in the base executorch_jni target
(line 76). The training and llama conditional blocks were adding it
again via target_sources, causing it to be compiled up to 3 times
into the same shared library.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17634

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 41 Pending

As of commit dc2c1e1 with merge base cf08087 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review February 23, 2026 20:27
Copilot AI review requested due to automatic review settings February 23, 2026 20:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes duplicate compilations of jni/log.cpp in the Android CMakeLists.txt file. The log.cpp file is already included in the base executorch_jni target (line 76), but was being added again in the training and llama conditional blocks, potentially causing it to be compiled up to 3 times into the same shared library.

Changes:

  • Removed jni/log.cpp from the EXECUTORCH_BUILD_EXTENSION_TRAINING conditional block
  • Removed jni/log.cpp from the EXECUTORCH_BUILD_LLAMA_JNI conditional block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kirklandsign kirklandsign merged commit 67f1d19 into main Feb 23, 2026
200 of 210 checks passed
@kirklandsign kirklandsign deleted the android/fix-duplicate-log-cpp branch February 23, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants