Remove duplicate log.cpp compilation in Android CMakeLists#17634
Remove duplicate log.cpp compilation in Android CMakeLists#17634kirklandsign merged 1 commit intomainfrom
Conversation
jni/log.cpp is already included in the base executorch_jni target (line 76). The training and llama conditional blocks were adding it again via target_sources, causing it to be compiled up to 3 times into the same shared library.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17634
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 41 PendingAs of commit dc2c1e1 with merge base cf08087 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate compilations of jni/log.cpp in the Android CMakeLists.txt file. The log.cpp file is already included in the base executorch_jni target (line 76), but was being added again in the training and llama conditional blocks, potentially causing it to be compiled up to 3 times into the same shared library.
Changes:
- Removed
jni/log.cppfrom theEXECUTORCH_BUILD_EXTENSION_TRAININGconditional block - Removed
jni/log.cppfrom theEXECUTORCH_BUILD_LLAMA_JNIconditional block
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
jni/log.cpp is already included in the base executorch_jni target (line 76). The training and llama conditional blocks were adding it again via target_sources, causing it to be compiled up to 3 times into the same shared library.
Test plan
CI