Add re2 shim for Buck2 OSS builds#17638
Merged
larryliu0820 merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
The tokenizers submodule BUCK file references `fbsource//third-party/re2:re2` directly, which resolves to `shim_et//third-party/re2:re2` in OSS via the `.buckconfig` alias. This target didn't exist, breaking Buck2 builds for any target depending on `tokenizers:headers`. Add a shim `cxx_library` that re-exports the local re2 build from `//extension/llm/tokenizers/third-party:re2`. This PR was authored with the assistance of Claude.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17638
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 8 Pending, 1 Unrelated FailureAs of commit b1b9ada with merge base 0d9799f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
rascani
approved these changes
Feb 23, 2026
larryliu0820
added
the
release notes: none
kirklandsign
approved these changes
Feb 23, 2026
Updates the tokenizers submodule to pick up the fix that excludes two abseil utility programs (print_hash_of.cc and gaussian_distribution_gentables.cc) from the Buck build. These files define main() which overrides the weak gtest main from UnitTestMain.cpp, causing test binaries to silently fail.
larryliu0820
force-pushed
the
fix-buck2-re2-shim
branch
from
a16649c to
b1b9ada
Compare
larryliu0820
added a commit
that referenced
this pull request
Feb 24, 2026
This is a follow-up of #17638 since it's breaking internal. The tokenizers BUCK file references fbsource//third-party/re2:re2, which resolves to shim_et//third-party/re2:re2 in OSS builds. This target didn't exist, causing Buck2 build failures. Add a shim cxx_library in shim_et/third-party/re2/ that re-exports from the actual re2 build in extension/llm/tokenizers/third-party. The shim is gated behind runtime.is_oss so it's a no-op internally. This PR was authored with the help of Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizers submodule BUCK file references
fbsource//third-party/re2:re2directly, which resolves toshim_et//third-party/re2:re2in OSS via the.buckconfigalias. This target didn't exist, breaking Buck2 builds for any target depending ontokenizers:headers.Add a shim
cxx_librarythat re-exports the local re2 build from//extension/llm/tokenizers/third-party:re2.This PR was authored with the assistance of Claude.