Deduplicate file validation and UTF-8 checking utilities

[kirklandsign]

Summary

Java: Extract validateFilePath() into ExecuTorchRuntime and replace inline checks in Module, LlmModule, and TrainingModule. This also removes the "!!" typo in TrainingModule error messages.

C++: Move utf8_check_validity() from anonymous namespaces in jni_layer_llama.cpp and jni_layer_asr.cpp into the shared jni_helper.h/.cpp.

Test plan

CI

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17648

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 35 Pending

As of commit 16a2501 with merge base c4e325d ():

NEW FAILURES - The following jobs have failed:

• pull / test-mediatek-models-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 686a3fe0afd1ca0ab7e28a94e083eb77102421bca365ee3bf75b5ba5653907c2 /exec failed with exit code 2
• pull / test-openvino-linux / linux-job (gh)
  RuntimeError: Command docker exec -t e1abf956d69c70cd323f1177a60277d216d5842a62da7a7c422949677b40b22b /exec failed with exit code 1
• pull / unittest-buck / linux / linux-job (gh)
  RuntimeError: Command docker exec -t a6e4db157c234a3d69bca99aa48ff3c1a1e6a37a6c754082c2dddd7ff71a7169 /exec failed with exit code 3

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[Copilot]

Pull request overview

This PR deduplicates common validation utilities across the Android Java API surface and Android JNI C++ layer by centralizing file-path validation in ExecuTorchRuntime and UTF-8 validity checking in jni_helper.

Changes:

• Java: Added ExecuTorchRuntime.validateFilePath() and replaced duplicated java.io.File readability checks in Module, LlmModule, and TrainingModule (also removing the “!!” typo in TrainingModule errors).
• C++: Moved utf8_check_validity() from per-file anonymous namespaces into shared jni_helper.h/.cpp and updated JNI layers to reuse it.
• JNI: Added jni_helper.h include where needed and imported the shared UTF-8 validator.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
extension/android/jni/jni_layer_llama.cpp	Replaces local UTF-8 validator with shared jni_helper implementation.
extension/android/jni/jni_layer_asr.cpp	Includes jni_helper.h and switches to shared UTF-8 validator.
extension/android/jni/jni_helper.h	Declares shared utf8_check_validity() (adds required includes).
extension/android/jni/jni_helper.cpp	Defines shared utf8_check_validity() implementation.
extension/android/executorch_android/src/main/java/org/pytorch/executorch/training/TrainingModule.java	Uses centralized file validation and removes duplicated checks/typo.
extension/android/executorch_android/src/main/java/org/pytorch/executorch/extension/llm/LlmModule.java	Uses centralized file validation instead of inline File checks.
extension/android/executorch_android/src/main/java/org/pytorch/executorch/Module.java	Uses centralized file validation instead of inline File checks.
extension/android/executorch_android/src/main/java/org/pytorch/executorch/ExecuTorchRuntime.java	Adds validateFilePath() utility for reuse across modules.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

ExecuTorchRuntime runtime = ExecuTorchRuntime.getRuntime(); is assigned but never used. Consider removing the local variable (and the call if it’s no longer needed) to avoid unused-variable warnings and reduce redundant initialization work.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.