Use GH built-in runner for link check workflow#17682
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17682
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 46 PendingAs of commit c7d3492 with merge base 7e1e6b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable link-check workflow to run directly on GitHub-hosted runners (ubuntu-latest) instead of delegating to the pytorch/test-infra reusable workflow and its Docker image, keeping the existing lint script behavior while reducing runtime and required permissions.
Changes:
- Replaced
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@mainwithruns-on: ubuntu-latest+actions/checkout@v4for each link-check job. - Set minimal job permissions (
contents: read) and removed the previously impliedid-token: writeneed. - Preserved the existing script invocation logic, including diff-range selection and error messaging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
…t scripts Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Summary
Reduce the job time from 6 minutes to 10 seconds.
Replace
pytorch/test-infrareusable workflow + Docker image with directubuntu-latestrunner for_link_check.yml. The lint scripts only need standard tools (curl,jq,perl,git,grep,sed) already on GH hosted runners. Saves server run hours and cost.lint-urls,lint-xrefs,lint-file-size) fromlinux_job_v2.yml+executorch-ubuntu-22.04-linterDocker image toruns-on: ubuntu-latestwithactions/checkout@v4id-token: writepermission (not needed; calling workflow doesn't grant it)fetch-depth: 0(full clone) with shallow checkout + targetedgit fetch --depth=1of the base SHA...) with two-dot (..) ingit diffacrosslint_urls.sh,lint_xrefs.sh,lint_file_size.sh— direct base-to-head diff, no merge-base lookup neededTest plan
CI — the link check jobs run on this PR.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.