4/x: Add LoadBackendOptionsMap support to Module::load()#17687
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17687
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit bd530b3 with merge base 19de115 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92358607. |
larryliu0820
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
bac6930 to
a3d9f72
Compare
Summary:
This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time.
Key changes:
- Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter
- Options are forwarded through the executor layer to backend delegates
- Backward compatible: existing `load()` calls continue to work without options
This completes the end-to-end user flow:
```cpp
// Configure backend options
LoadOptionsBuilder coreml_opts;
coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU);
LoadBackendOptionsMap options;
options.set_options(coreml_opts);
// Load model with options
Module module(model_path);
module.load("forward", options);
```
Reviewed By: larryliu0820
Differential Revision: D92358607
Summary: Pull Request resolved: pytorch#17687 This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time. Key changes: - Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter - Options are forwarded through the executor layer to backend delegates - Backward compatible: existing `load()` calls continue to work without options This completes the end-to-end user flow: ```cpp // Configure backend options LoadOptionsBuilder coreml_opts; coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU); LoadBackendOptionsMap options; options.set_options(coreml_opts); // Load model with options Module module(model_path); module.load("forward", options); ``` Reviewed By: larryliu0820 Differential Revision: D92358607
a3d9f72 to
867a1fd
Compare
Summary:
This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time.
Key changes:
- Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter
- Options are forwarded through the executor layer to backend delegates
- Backward compatible: existing `load()` calls continue to work without options
This completes the end-to-end user flow:
```cpp
// Configure backend options
LoadOptionsBuilder coreml_opts;
coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU);
LoadBackendOptionsMap options;
options.set_options(coreml_opts);
// Load model with options
Module module(model_path);
module.load("forward", options);
```
Reviewed By: larryliu0820
Differential Revision: D92358607
867a1fd to
c3e3994
Compare
Summary: Pull Request resolved: pytorch#17687 This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time. Key changes: - Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter - Options are forwarded through the executor layer to backend delegates - Backward compatible: existing `load()` calls continue to work without options This completes the end-to-end user flow: ```cpp // Configure backend options LoadOptionsBuilder coreml_opts; coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU); LoadBackendOptionsMap options; options.set_options(coreml_opts); // Load model with options Module module(model_path); module.load("forward", options); ``` Reviewed By: larryliu0820 Differential Revision: D92358607
4a6df62 to
e78661a
Compare
Summary:
This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time.
Key changes:
- Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter
- Options are forwarded through the executor layer to backend delegates
- Backward compatible: existing `load()` calls continue to work without options
This completes the end-to-end user flow:
```cpp
// Configure backend options
LoadOptionsBuilder coreml_opts;
coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU);
LoadBackendOptionsMap options;
options.set_options(coreml_opts);
// Load model with options
Module module(model_path);
module.load("forward", options);
```
Reviewed By: larryliu0820
Differential Revision: D92358607
Summary: Pull Request resolved: pytorch#17687 This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time. Key changes: - Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter - Options are forwarded through the executor layer to backend delegates - Backward compatible: existing `load()` calls continue to work without options This completes the end-to-end user flow: ```cpp // Configure backend options LoadOptionsBuilder coreml_opts; coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU); LoadBackendOptionsMap options; options.set_options(coreml_opts); // Load model with options Module module(model_path); module.load("forward", options); ``` Reviewed By: larryliu0820 Differential Revision: D92358607
e78661a to
7af3852
Compare
Summary:
This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time.
Key changes:
- Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter
- Options are forwarded through the executor layer to backend delegates
- Backward compatible: existing `load()` calls continue to work without options
This completes the end-to-end user flow:
```cpp
// Configure backend options
LoadOptionsBuilder coreml_opts;
coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU);
LoadBackendOptionsMap options;
options.set_options(coreml_opts);
// Load model with options
Module module(model_path);
module.load("forward", options);
```
Reviewed By: larryliu0820
Differential Revision: D92358607
7af3852 to
c290017
Compare
Summary: Pull Request resolved: pytorch#17687 This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time. Key changes: - Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter - Options are forwarded through the executor layer to backend delegates - Backward compatible: existing `load()` calls continue to work without options This completes the end-to-end user flow: ```cpp // Configure backend options LoadOptionsBuilder coreml_opts; coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU); LoadBackendOptionsMap options; options.set_options(coreml_opts); // Load model with options Module module(model_path); module.load("forward", options); ``` Reviewed By: larryliu0820 Differential Revision: D92358607
c290017 to
2beb57e
Compare
Summary:
This diff exposes the `LoadBackendOptionsMap` API at the `Module` level, providing the user-facing interface for configuring backend options at model load time.
Key changes:
- Added `Module::load()` overload accepting `LoadBackendOptionsMap` parameter
- Options are forwarded through the executor layer to backend delegates
- Backward compatible: existing `load()` calls continue to work without options
This completes the end-to-end user flow:
```cpp
// Configure backend options
LoadOptionsBuilder coreml_opts;
coreml_opts.setComputeUnit(LoadOptionsBuilder::ComputeUnit::CPU_AND_GPU);
LoadBackendOptionsMap options;
options.set_options(coreml_opts);
// Load model with options
Module module(model_path);
module.load("forward", options);
```
Reviewed By: larryliu0820
Differential Revision: D92358607
2beb57e to
bd530b3
Compare
Summary:
This diff exposes the
LoadBackendOptionsMapAPI at theModulelevel, providing the user-facing interface for configuring backend options at model load time.Key changes:
Module::load()overload acceptingLoadBackendOptionsMapparameterload()calls continue to work without optionsThis completes the end-to-end user flow:
Reviewed By: larryliu0820
Differential Revision: D92358607