Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17867
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 1 New Failure, 3 Unrelated FailuresAs of commit 31c6aa8 with merge base 75f5a76 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the size test when compiled with GCC 11. GCC 11 produces a false positive -Wstringop-overread warning in Flatbuffers-generated code (program_generated.h), which is promoted to an error by -Werror. The fix suppresses this specific warning via -Wno-stringop-overread.
Changes:
- Added
-Wno-stringop-overreadtoCOMMON_CXXFLAGSin the size test build script to suppress a false positive GCC 11 warning in Flatbuffers-generated code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -15,7 +15,7 @@ EXTRA_BUILD_ARGS="${@:-}" | |||
| # TODO(#8357): Remove -Wno-int-in-bool-context | |||
There was a problem hiding this comment.
The existing -Wno-int-in-bool-context flag has a TODO comment (line 15) explaining why it's there and that it should eventually be removed. Consider adding a similar TODO comment for -Wno-stringop-overread to document that it's a workaround for a GCC 11 false positive in Flatbuffers-generated code, and can potentially be removed when GCC 11 is no longer a supported compiler.
| # TODO(#8357): Remove -Wno-int-in-bool-context | |
| # TODO(#8357): Remove -Wno-int-in-bool-context | |
| # TODO: Remove -Wno-stringop-overread once GCC 11 is no longer supported. | |
| # This flag works around a GCC 11 false positive in Flatbuffers-generated code. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| @@ -15,7 +15,7 @@ EXTRA_BUILD_ARGS="${@:-}" | |||
| # TODO(#8357): Remove -Wno-int-in-bool-context | |||
| # TODO: Replace -ET_HAVE_PREAD=0 with a CMake option. | |||
| # FileDataLoader used in the size_test breaks baremetal builds with pread when missing. | |||
There was a problem hiding this comment.
Consider adding a TODO comment for -Wno-stringop-overread, similar to the existing # TODO(#8357): Remove -Wno-int-in-bool-context on line 15, to track when this suppression can be removed (e.g., when the FlatBuffers version is updated or the GCC11 false positive is resolved). This helps prevent warning suppressions from accumulating without tracking.
| # FileDataLoader used in the size_test breaks baremetal builds with pread when missing. | |
| # FileDataLoader used in the size_test breaks baremetal builds with pread when missing. | |
| # TODO: Remove -Wno-stringop-overread once the GCC11 FlatBuffers false positive is resolved or FlatBuffers is updated. |
|
duplicate of #17905, sorry @kirklandsign 😅 |
Summary
size_test on gcc11 fails with
Test plan
Flatbuffer should be safe - add -Wno-stringop-overread to suppress the error.
size results after stripping