Skip to content

Suppress .eh_frame generation when EXECUTORCH_OPTIMIZE_SIZE is ON #17906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucylq merged 14 commits into from
Mar 6, 2026
Merged

Suppress .eh_frame generation when EXECUTORCH_OPTIMIZE_SIZE is ON #17906

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d863233
Update
Mar 5, 2026
4d61d78
Update
Mar 5, 2026
b5c55ae
Update
Mar 5, 2026
e9a15c2
Update
Mar 5, 2026
1c5037c
Update
Mar 5, 2026
6d658ea
Update
Mar 5, 2026
25dc1d2
Update
Mar 6, 2026
a8e3fc4
Update
Mar 6, 2026
cf6ca45
Update
Mar 6, 2026
508f6ca
Update
Mar 6, 2026
6fd7d80
Update
Mar 6, 2026
9492055
Update
Mar 6, 2026
deb9518
Update
Mar 6, 2026
f613426
Update
Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,23 @@ endif()

add_subdirectory(third-party)

# Size-optimized builds disable exceptions, RTTI, and unwind tables.
# ExecuTorch's runtime uses Result<T>/Error instead of exceptions, so
# -fno-exceptions is safe. Suppressing .eh_frame via -fno-unwind-tables is safe
# because exceptions are disabled. Placed after add_subdirectory(third-party) to
# avoid leaking into third-party configure checks (e.g. gflags).
if(EXECUTORCH_OPTIMIZE_SIZE
AND NOT WIN32
AND NOT MSVC
)
set(CMAKE_CXX_FLAGS_RELEASE
"${CMAKE_CXX_FLAGS_RELEASE} -fno-exceptions -fno-rtti -fno-asynchronous-unwind-tables -fno-unwind-tables"
)
Comment on lines +233 to +235
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the change only adds -fno-asynchronous-unwind-tables/-fno-unwind-tables, but this hunk also adds -fno-exceptions and -fno-rtti to CMAKE_CXX_FLAGS_RELEASE. Please update the PR description (or drop the extra flags) so reviewers/users understand the full behavior change.

Copilot uses AI. Check for mistakes.
set(CMAKE_C_FLAGS_RELEASE
"${CMAKE_C_FLAGS_RELEASE} -fno-asynchronous-unwind-tables -fno-unwind-tables"
)
endif()

if(NOT DEFINED FXDIV_SOURCE_DIR)
set(ORIGINAL_CMAKE_POSITION_INDEPENDENT_CODE_FLAG
${CMAKE_POSITION_INDEPENDENT_CODE}
Expand Down
Loading