Skip to content

Upgrade aws-actions/configure-aws-credentials from v1.7.0 to v4#18216

Merged
kirklandsign merged 1 commit intomainfrom
android/update-release-artifacts-node20
Apr 1, 2026
Merged

Upgrade aws-actions/configure-aws-credentials from v1.7.0 to v4#18216
kirklandsign merged 1 commit intomainfrom
android/update-release-artifacts-node20

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

Summary

v1.7.0 uses Node.js 20 which is deprecated and will be forced to Node.js 24 starting June 2026. It also uses the deprecated set-output command. v4 supports Node.js 24 and uses Environment Files.

Test plan

CI

v1.7.0 uses Node.js 20 which is deprecated and will be forced to
Node.js 24 starting June 2026. It also uses the deprecated set-output
command. v4 supports Node.js 24 and uses Environment Files.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 16, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18216

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit e917706 with merge base d0820e1 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kirklandsign kirklandsign marked this pull request as ready for review March 16, 2026 23:14
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2026
Copilot AI review requested due to automatic review settings March 16, 2026 23:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to use the latest major version of aws-actions/configure-aws-credentials, aligning CI credential configuration with the supported Node runtime and output mechanisms.

Changes:

  • Bump aws-actions/configure-aws-credentials from v1.7.0 to v4 in the Apple frameworks upload workflow.
  • Bump aws-actions/configure-aws-credentials from v1.7.0 to v4 in the Android release artifacts upload workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/apple.yml Updates AWS credentials action used for uploading iOS frameworks.
.github/workflows/android-release-artifacts.yml Updates AWS credentials action used for uploading Android AAR artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 16, 2026

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this in D96839890.

@kirklandsign kirklandsign merged commit 7004989 into main Apr 1, 2026
243 of 247 checks passed
@kirklandsign kirklandsign deleted the android/update-release-artifacts-node20 branch April 1, 2026 21:25
Jiseong-oh pushed a commit to Jiseong-oh/executorch that referenced this pull request Apr 2, 2026
…rch#18216)

v1.7.0 uses Node.js 20 which is deprecated and will be forced to Node.js
24 starting June 2026. It also uses the deprecated set-output command.
v4 supports Node.js 24 and uses Environment Files.
Jiseong-oh pushed a commit that referenced this pull request Apr 2, 2026
v1.7.0 uses Node.js 20 which is deprecated and will be forced to Node.js
24 starting June 2026. It also uses the deprecated set-output command.
v4 supports Node.js 24 and uses Environment Files.
Jiseong-oh pushed a commit that referenced this pull request Apr 7, 2026
v1.7.0 uses Node.js 20 which is deprecated and will be forced to Node.js
24 starting June 2026. It also uses the deprecated set-output command.
v4 supports Node.js 24 and uses Environment Files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants