Qualcomm AI Engine Direct - Resolved RMSNorm issue without weight#18219
Conversation
- Added a test case for torch.nn.RMSNorm([4], elementwise_affine=False). - Verified whether weight exists in the op builder. - Used an all-ones weight tensor for identity scaling if no weight is present. - Fix htp_rules.py RmsNorm annotator to skip weight annotation when weight is absent.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18219
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 4dac95e with merge base a81ef44 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Hi @cccclai, @abhinaykukkadapu, This PR addresses the issue regarding RMSNorm without weight reported by a Discord user. Thanks, |
abhinaykukkadapu
left a comment
There was a problem hiding this comment.
Looks great, thanks for fixing this.
Summary
Test plan