Add NHWC version of max_pool2d (#18239)#18239

Open

mcremon-meta wants to merge 2 commits intomainfrom

export-D96869747

Contributor

mcremon-meta commented Mar 17, 2026 •

edited by meta-codesync bot

Loading

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

pytorch-bot bot commented Mar 17, 2026 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18239

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 7 Pending, 2 Unrelated Failures

As of commit e427b01 with merge base eb92cec ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / unittest-editable / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

meta-codesync bot commented Mar 17, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96869747.

meta-codesync bot added fb-exported meta-exported labels

github-actions bot commented Mar 17, 2026

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

hsharma35 approved these changes

View reviewed changes

meta-codesync bot changed the title ~~Add NHWC version of max_pool2d~~ Add NHWC version of max_pool2d (#18239)

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

22c1dcf

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

meta-codesync bot force-pushed the export-D96869747 branch from d5f5879 to 22c1dcf Compare

March 17, 2026 17:43

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

2828d9e

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

273ea0a

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

mcremon-meta force-pushed the export-D96869747 branch from 22c1dcf to 273ea0a Compare

March 17, 2026 17:47

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

f205f54

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

meta-codesync bot force-pushed the export-D96869747 branch from 273ea0a to 75db344 Compare

March 17, 2026 17:56

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

75db344

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

1c565e1

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

mcremon-meta force-pushed the export-D96869747 branch from 75db344 to 908826d Compare

March 17, 2026 18:04

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

908826d

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

0dd28f3

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

7c5fadd

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

7221ed6

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot force-pushed the export-D96869747 branch from 908826d to 7221ed6 Compare

March 18, 2026 15:58

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

c55db0f

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

mcremon-meta force-pushed the export-D96869747 branch from 7221ed6 to c55db0f Compare

March 18, 2026 16:01


          Add quantized max_pool2d operator (#18202)

6c6819c

Summary:
Pull Request resolved: #18202

As titled. Useful especially for resnet backbones, to reduce quant/dequant pressure.

Differential Revision: D96683989

Reviewed By: DrJessop

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

c4d06b6

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot force-pushed the export-D96869747 branch from c55db0f to c4d06b6 Compare

March 18, 2026 16:19

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

167dbf8

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

mcremon-meta force-pushed the export-D96869747 branch from c4d06b6 to 167dbf8 Compare

March 18, 2026 16:22

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

566b828

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

Reviewed By: hsharma35

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

d0b8784

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

613e11d

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

4aef87b

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

4c315ac

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot force-pushed the export-D96869747 branch from 167dbf8 to 4c315ac Compare

March 18, 2026 16:50

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

cf57373

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747


          Add NHWC version of max_pool2d (#18239)

e427b01

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

mcremon-meta force-pushed the export-D96869747 branch from 4c315ac to e427b01 Compare

March 18, 2026 16:53

mcremon-meta added a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

e3a166f

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

Reviewed By: hsharma35

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

89a3b6f

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

meta-codesync bot pushed a commit that referenced this pull request


          Add NHWC version of max_pool2d (#18239)

a3b7f63

Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported meta-exported