Skip to content

Fix weight cache bug #18295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoryComer merged 2 commits into from
Mar 18, 2026
Merged

Fix weight cache bug #18295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8e31e
Fix weight cache bug
GregoryComer Mar 18, 2026
bb64d12
Lint
GregoryComer Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backends/xnnpack/runtime/XNNWeightsCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,18 @@ size_t XNNWeightsCache::look_up_or_insert(
size_t size) {
size_t offset = context->look_up(context, cache_key);

// XNNPACK can call this with ptr==nullptr when it previously hit the cache
// and skipped packing. We can't validate against the ptr contents in this
// case, so just return the offset. This might actually be a bug in XNNPACK
// since calling look_up_or_insert with ptr==nullptr doesn't really make
// sense...
if (ptr == nullptr) {
return offset;
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worst case we will return SIZE_MAX?
And we can't continue without ptr from here anyway.

}

if (offset != SIZE_MAX) {
void* saved_ptr = context->offset_to_addr(context, offset);
if (0 == memcmp(ptr, saved_ptr, size)) {
if (saved_ptr != nullptr && 0 == memcmp(ptr, saved_ptr, size)) {
return offset;
}
// Failure, cache is out of date
Expand Down
Loading