Add LoRA multimethod export to CoreML static LLM export#18347
Open
lucylq wants to merge 7 commits intogh/lucylq/145/headfrom
Open
Add LoRA multimethod export to CoreML static LLM export#18347lucylq wants to merge 7 commits intogh/lucylq/145/headfrom
lucylq wants to merge 7 commits intogh/lucylq/145/headfrom
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18347
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit 7968c1b with merge base 02bad9d ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Mar 19, 2026
Add --adapter CLI for exporting LoRA adapters as separate methods in a CoreML PTE. CoreML POSITIONAL weight sharing deduplicates base weights across methods. Supports combination with --multifunction for decode/prefill variants per adapter. Authored with Claude. ghstack-source-id: 16ab852 ghstack-comment-id: 4093498502 Pull-Request: #18347
lucylq
added a commit
that referenced
this pull request
Mar 19, 2026
Add --adapter CLI for exporting LoRA adapters as separate methods in a CoreML PTE. CoreML POSITIONAL weight sharing deduplicates base weights across methods. Supports combination with --multifunction for decode/prefill variants per adapter. Authored with Claude. ghstack-source-id: eaac058 ghstack-comment-id: 4093498502 Pull-Request: #18347
lucylq
added a commit
that referenced
this pull request
Mar 19, 2026
Add --adapter CLI for exporting LoRA adapters as separate methods in a CoreML PTE. CoreML POSITIONAL weight sharing deduplicates base weights across methods. Supports combination with --multifunction for decode/prefill variants per adapter. Authored with Claude. ghstack-source-id: d3fc801 ghstack-comment-id: 4093498502 Pull-Request: #18347
lucylq
added a commit
that referenced
this pull request
Mar 19, 2026
Add --adapter CLI for exporting LoRA adapters as separate methods in a CoreML PTE. CoreML POSITIONAL weight sharing deduplicates base weights across methods. Supports combination with --multifunction for decode/prefill variants per adapter. Authored with Claude. ghstack-source-id: 54b25aa ghstack-comment-id: 4093498502 Pull-Request: #18347
lucylq
commented
Mar 20, 2026
| "forward": _export_model(model, example_inputs, "base"), | ||
| } | ||
| for name, lora_model in lora_models.items(): | ||
| methods[name] = _export_model(lora_model, example_inputs, name) |
Contributor
Author
There was a problem hiding this comment.
add methods for each lora
lucylq
commented
Mar 20, 2026
| methods[f"{name}_forward"] = _export_model( | ||
| lora_model, decode_inputs, f"{name} decode" | ||
| ) | ||
| methods[f"{name}_prefill"] = _export_model( |
Contributor
Author
There was a problem hiding this comment.
add methods for each lora with separate prefill, decode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --adapter CLI for exporting LoRA adapters as separate methods in
a CoreML PTE. CoreML POSITIONAL weight sharing deduplicates base weights
across methods. Supports combination with --multifunction for
decode/prefill variants per adapter.
Authored with Claude.