Skip to content

Make extract_coreml_models.py buck-runnable (#18371)#18371

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
derekxu:export-D97498856
Mar 23, 2026
Merged

Make extract_coreml_models.py buck-runnable (#18371)#18371
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
derekxu:export-D97498856

Conversation

@derekxu
Copy link
Copy Markdown
Contributor

@derekxu derekxu commented Mar 20, 2026

Summary:

Add a python_binary target for extract_coreml_models.py in the BUCK file,
wrap the script's entry point in a main() function

Reviewed By: metascroy

Differential Revision: D97498856

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18371

Note: Links to docs will display an error until the docs builds have been completed.

❌ 54 New Failures, 1 Pending, 2 Unrelated Failures

As of commit f03feea with merge base 6d04ed3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 20, 2026

@derekxu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97498856.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Add a python_binary target for extract_coreml_models.py in the BUCK file,
wrap the script's entry point in a main() function

Reviewed By: metascroy

Differential Revision: D97498856
@meta-codesync meta-codesync Bot changed the title Make extract_coreml_models.py buck-runnable Make extract_coreml_models.py buck-runnable (#18371) Mar 23, 2026
@meta-codesync meta-codesync Bot merged commit 2f496bb into pytorch:main Mar 23, 2026
83 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants