Arm backend: Refactor scalar handling#18402
Merged
Merged
Conversation
Scalars are then converted to buffers by the ScalarsToAttribute pass. This both simplifies the code, and allows affected ops to be moved to device with model.to(device=...). Note that this does not solve all issues with device kwargs after TFA, only specifically for scalar cases. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I65c4ac69ec8fbfae98d8660a670658af6ea2eca8
- The ScalarToAttribute pass went through all submodules for each node, it only needs to do it once. - Some exir passes used full_like for scalars. This creates very buffers of the same size as the input, when a single value is enough. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ie48cec7dd2f78855eda90811fd1bc7dfec7d3a15
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18402
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Pending, 5 Unrelated FailuresAs of commit 2087f35 with merge base f7977a6 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Mar 23, 2026
Collaborator
Author
|
Unrelated failures, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm backend: use scalars instead of fulls in TFA
Arm backend: Clean up some pass inefficiencies.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell