[QNN] Harden SDK download and skip auto-download in CI#18416
Merged
abhinaykukkadapu merged 1 commit intoMar 23, 2026
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18416
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 90 PendingAs of commit 29e8b7f with merge base 6d04ed3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
28d6809 to
eef38b8
Compare
Summary: Gracefully skip QNN backend when the download server is unreachable (e.g. devvms without proxy) and harden the SDK download against flaky connections. - Add --check flag to download_qnn_sdk.py that probes server reachability via requests.head() (proxy-aware) - Skip QNN in GitHub Actions CI unless QNN_SDK_ROOT is set - Increase download retries (3→5) with exponential backoff and timeouts - Validate archive integrity after download to catch truncation - Verify downloaded size matches Content-Length to trigger retries on incomplete downloads Test Plan: Tested on devvm without proxy (QNN skipped), with proxy (QNN downloaded), with QNN_SDK_ROOT set (QNN enabled), and with -DEXECUTORCH_BUILD_QNN=ON.
eef38b8 to
29e8b7f
Compare
shoumikhin
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.3GB QNN SDK download fails in GitHub Actions CI due to ChunkedEncodingError after exhausting 3 retries. The connection drops around 80% completion consistently.
--checkflag to download_qnn_sdk.py that probes server reachability via requests.head() (proxy-aware)Test Plan:
Local
pip install -e .still auto-downloads QNN SDK on Linux x86_64. CI builds without QNN_SDK_ROOT skip QNN gracefully with a status message.