Fix Docker build failure for cuda-windows image by using CUDA_VERSION build arg#18456
Merged
manuelcandales merged 1 commit intorelease/1.2from Mar 24, 2026
Merged
Conversation
… build arg (#18435) The install_cuda_windows_cross_compile.sh script was querying PyTorch for its CUDA version, but PyTorch gets installed indirectly via pip dependencies (torchsr, timm) even when SKIP_PYTORCH=yes. This causes a failure if the pip-installed PyTorch reports a CUDA version which isn't in the version map. Pass the CUDA_VERSION Docker build arg to the script and prefer it over querying PyTorch. (cherry picked from commit 10d84aa)
This was referenced Mar 24, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18456
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
manuelcandales
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install_cuda_windows_cross_compile.sh script was querying PyTorch for its CUDA version, but PyTorch gets installed indirectly via pip dependencies (torchsr, timm) even when SKIP_PYTORCH=yes. This causes a failure if the pip-installed PyTorch reports a CUDA version which isn't in the version map. Pass the CUDA_VERSION Docker build arg to the script and prefer it over querying PyTorch.