Move graph_builder and program_builder to executorch.backends.test (#18483)#18483
Open
hsharma35 wants to merge 2 commits intopytorch:mainfrom
Open
Move graph_builder and program_builder to executorch.backends.test (#18483)#18483hsharma35 wants to merge 2 commits intopytorch:mainfrom
hsharma35 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18483
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 851825d with merge base b9a6b84 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97995878. |
meta-codesync
bot
changed the title
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 24, 2026
…ytorch#18483) Summary: Move `GraphBuilder` and `ProgramBuilder` from `executorch.backends.cadence.aot` to `executorch.backends.test` since they are general-purpose test utilities not specific to the Cadence backend. - Created new canonical modules at `executorch/backends/test/` - Old modules now re-export from the new location for backward compatibility - Updated all 12 downstream consumers to import from the new path - Updated BUCK targets: new targets in `backends/test/targets.bzl`, old targets now depend on new ones Differential Revision: D97995878
hsharma35
force-pushed
the
export-D97995878
branch
from
74b4123 to
448660e
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
…ytorch#18483) Summary: Pull Request resolved: pytorch#18483 Move `GraphBuilder` and `ProgramBuilder` from `executorch.backends.cadence.aot` to `executorch.backends.test` since they are general-purpose test utilities not specific to the Cadence backend. - Created new canonical modules at `executorch/backends/test/` - Old modules now re-export from the new location for backward compatibility - Updated all 12 downstream consumers to import from the new path - Updated BUCK targets: new targets in `backends/test/targets.bzl`, old targets now depend on new ones Differential Revision: D97995878
hsharma35
force-pushed
the
export-D97995878
branch
from
448660e to
1e82fc3
Compare
…nt (M6) Summary: In plan_with_constraints(), specs that arrive with a pre-set mem_id (e.g. planned-temporary alloc nodes whose spec.mem_id is pinned by the AOT pass) are promoted to AbsolutePlacementConstraint before the solver runs. The planner then assigns only the offset within that tier, leaving mem_id intact. Specs that already have an explicit AbsolutePlacementConstraint are not double-promoted — the existing constraint wins. Adds test target test_memory_planning_algo with 5 regression tests: - unpinned spec placed freely in mem_id=1 - pinned spec stays in the requested tier - two specs pinned to the same tier get non-overlapping offsets - unpinned peers of pinned specs are not forced into the pinned tier - an externally-set AbsolutePlacementConstraint overrides spec.mem_id This is Milestone 6 of the planned-temporaries feature. Differential Revision: D95413373
hsharma35
force-pushed
the
export-D97995878
branch
from
1e82fc3 to
3f8726c
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
…ytorch#18483) Summary: Move `GraphBuilder` and `ProgramBuilder` from `executorch.backends.cadence.aot` to `executorch.backends.test` since they are general-purpose test utilities not specific to the Cadence backend. - Created new canonical modules at `executorch/backends/test/` - Old modules now re-export from the new location for backward compatibility - Updated all 12 downstream consumers to import from the new path - Updated BUCK targets: new targets in `backends/test/targets.bzl`, old targets now depend on new ones Differential Revision: D97995878
…ytorch#18483) Summary: Pull Request resolved: pytorch#18483 Move `GraphBuilder` and `ProgramBuilder` from `executorch.backends.cadence.aot` to `executorch.backends.test` since they are general-purpose test utilities not specific to the Cadence backend. - Created new canonical modules at `executorch/backends/test/` - Old modules now re-export from the new location for backward compatibility - Updated all 12 downstream consumers to import from the new path - Updated BUCK targets: new targets in `backends/test/targets.bzl`, old targets now depend on new ones Differential Revision: D97995878
hsharma35
force-pushed
the
export-D97995878
branch
from
3f8726c to
851825d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
GraphBuilderandProgramBuilderfromexecutorch.backends.cadence.aotto
executorch.backends.testsince they are general-purpose test utilities notspecific to the Cadence backend.
executorch/backends/test/backends/test/targets.bzl, old targetsnow depend on new ones
Differential Revision: D97995878