Skip to content

Format third-party/CMakeLists.txt using cmake-format #18533

Merged
kirklandsign merged 2 commits intopytorch:mainfrom
aksharabhardwaj766-commits:format-cmakelists-v2
Apr 23, 2026
Merged

Format third-party/CMakeLists.txt using cmake-format #18533
kirklandsign merged 2 commits intopytorch:mainfrom
aksharabhardwaj766-commits:format-cmakelists-v2

Conversation

@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor

Fixes #10736

Formats third-party/CMakeLists.txt using cmake-format to improve readability and consistency.

Changes:

  • Reformatted ExternalProject_Add(...) blocks for flatbuffers and flatcc
  • Reflowed set_target_properties(...), set(...) cache variables, and install(...) calls
  • No functional changes — formatting only

Note: This is a clean replacement for #17374, which had accumulated unrelated files from merge conflict resolutions.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18533

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit efd725d with merge base d31d4be (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2026
@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor Author

aksharabhardwaj766-commits commented Mar 27, 2026

@pytorchbot label "release notes: none"

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 27, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot label: error: the following arguments are required: labels

usage: @pytorchbot label labels [labels ...]

Try @pytorchbot --help for more info.

@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor Author

@pytorchbot label release notes: none

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 27, 2026

Didn't find following labels among repository labels: release,notes:,none

@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Mar 27, 2026
@kirklandsign kirklandsign requested a review from Copilot March 27, 2026 18:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve readability/consistency of the project’s third-party build configuration by reformatting third-party/CMakeLists.txt using cmake-format.

Changes:

  • Reformats ExternalProject_Add(...) blocks for flatbuffers and flatcc.
  • Reflows several set_target_properties(...), cache set(...), and install(...) invocations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread third-party/CMakeLists.txt Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor Author

Hi @kirklandsign , just a gentle ping — this PR has been approved for about 3 weeks now. Would like to see it land whenever you have a moment. Thank you!

@kirklandsign kirklandsign merged commit 8a77f9b into pytorch:main Apr 23, 2026
158 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format CMakeLists.txt

4 participants