Format third-party/CMakeLists.txt using cmake-format #18533
Format third-party/CMakeLists.txt using cmake-format #18533kirklandsign merged 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18533
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit efd725d with merge base d31d4be ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: none" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot label release notes: none |
|
Didn't find following labels among repository labels: release,notes:,none |
|
@pytorchbot label "release notes: none" |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve readability/consistency of the project’s third-party build configuration by reformatting third-party/CMakeLists.txt using cmake-format.
Changes:
- Reformats
ExternalProject_Add(...)blocks forflatbuffersandflatcc. - Reflows several
set_target_properties(...), cacheset(...), andinstall(...)invocations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hi @kirklandsign , just a gentle ping — this PR has been approved for about 3 weeks now. Would like to see it land whenever you have a moment. Thank you! |
Fixes #10736
Formats
third-party/CMakeLists.txtusingcmake-formatto improve readability and consistency.Changes:
ExternalProject_Add(...)blocks forflatbuffersandflatccset_target_properties(...),set(...)cache variables, andinstall(...)callsNote: This is a clean replacement for #17374, which had accumulated unrelated files from merge conflict resolutions.