Skip to content

Fix HiFi conv2d_nhwc operator for depthwise case (again)#18559

Merged
meta-codesync[bot] merged 1 commit intomainfrom
export-D98634082
Mar 30, 2026
Merged

Fix HiFi conv2d_nhwc operator for depthwise case (again)#18559
meta-codesync[bot] merged 1 commit intomainfrom
export-D98634082

Conversation

@mcremon-meta
Copy link
Copy Markdown
Contributor

Summary: Seems like we let one case slip. Add a fallback for it.

Differential Revision: D98634082

Summary: Seems like we let one case slip. Add a fallback for it.

Differential Revision: D98634082
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 29, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18559

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit b08eb3d with merge base 502d2de (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 29, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98634082.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit 2426951 into main Mar 30, 2026
167 of 177 checks passed
@meta-codesync meta-codesync Bot deleted the export-D98634082 branch March 30, 2026 20:38
rascani pushed a commit to rascani/executorch that referenced this pull request Apr 1, 2026
Differential Revision: D98634082

Pull Request resolved: pytorch#18559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants