Fix QNN Android AAR build#18579
Merged
manuelcandales merged 1 commit intorelease/1.2from Mar 30, 2026
Merged
Conversation
Add missing attention_sink_rope_runner.cpp to Android JNI build This fixes a linker error when building libexecutorch_jni.so for the QNN flavor of the Android AAR. The QNN llama runner sources (lhd_token_generator.cpp, token_generator.cpp, prompt_processor.cpp, runner.cpp) reference AttentionSinkRopeRunner but its implementation wasn't being compiled into the JNI library. (cherry picked from commit 6b2537d)
This was referenced Mar 30, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18579
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
manuelcandales
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing attention_sink_rope_runner.cpp to Android JNI build
This fixes a linker error when building libexecutorch_jni.so for the QNN flavor of the Android AAR. The QNN llama runner sources (lhd_token_generator.cpp, token_generator.cpp, prompt_processor.cpp, runner.cpp) reference AttentionSinkRopeRunner but its implementation wasn't being compiled into the JNI library.