Skip to content

solve et lint-mypy issue (#18587)#18587

Merged
Gasoonjia merged 1 commit intomainfrom
export-D98762153
Mar 30, 2026
Merged

solve et lint-mypy issue (#18587)#18587
Gasoonjia merged 1 commit intomainfrom
export-D98762153

Conversation

@Gasoonjia
Copy link
Copy Markdown
Contributor

@Gasoonjia Gasoonjia commented Mar 30, 2026 •
edited by meta-codesync Bot
Loading

Summary:

try to solve lint-mypy issue in torch.hud

Differential Revision: D98762153

@Gasoonjia Gasoonjia requested a review from digantdesai as a code owner March 30, 2026 17:52
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 30, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18587

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 30 Pending

As of commit 242a7fb with merge base 02cb325 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 30, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 30, 2026

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98762153.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia @facebook-github-bot
solve et lint-mypy issue (#18587)
242a7fb 
Summary:

try to solve lint-mypy issue in torch.hud

Differential Revision: D98762153
@meta-codesync meta-codesync Bot changed the title solve et lint-mypy issue solve et lint-mypy issue (#18587) Mar 30, 2026
@Gasoonjia Gasoonjia merged commit dd9a053 into main Mar 30, 2026
159 of 164 checks passed
@Gasoonjia Gasoonjia deleted the export-D98762153 branch March 30, 2026 18:14
@manuelcandales
Copy link
Copy Markdown
Contributor

manuelcandales commented Mar 30, 2026

@pytorchbot cherry-pick --onto release/1.2 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 30, 2026
@Gasoonjia @pytorchbot
solve et lint-mypy issue (#18587) (#18587)
18d8b46 
Summary:

try to solve lint-mypy issue in torch.hud

Differential Revision: D98762153

(cherry picked from commit dd9a053)
@pytorchbot
Copy link
Copy Markdown
Collaborator

pytorchbot commented Mar 30, 2026

Cherry picking #18587

The cherry pick PR is at #18591 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Mar 30, 2026
Closed
manuelcandales pushed a commit that referenced this pull request Mar 30, 2026
@pytorchbot @Gasoonjia
solve et lint-mypy issue (#18587) (#18591)
95b50de 
Summary:

try to solve lint-mypy issue in torch.hud

Differential Revision: D98762153

Co-authored-by: Gasoonjia <gasoonjia@icloud.com>
rascani pushed a commit to rascani/executorch that referenced this pull request Apr 1, 2026
@Gasoonjia @rascani
solve et lint-mypy issue (pytorch#18587) (pytorch#18587)
1ee3726 
Summary:

try to solve lint-mypy issue in torch.hud

Differential Revision: D98762153
@AdrianLundell
Copy link
Copy Markdown
Collaborator

AdrianLundell commented Apr 10, 2026

Hi, FYI I had another fix for this issue which should avoid similar problems from reappearing in the future, do you want to have a look at it? #18535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes

@lucylq lucylq lucylq approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gasoonjia @manuelcandales @pytorchbot @AdrianLundell @rascani @lucylq