Fix avg_pool2d divisor_override being ignored when count_include_pad is false. (#18616)#18616
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Apr 7, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18616
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 62b4531 with merge base 3d2c853 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
This PR needs a
|
DrJessop
approved these changes
Apr 1, 2026
meta-codesync
Bot
changed the title
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
Apr 1, 2026
…is false. (pytorch#18616) Summary: When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count. Reviewed By: DrJessop Differential Revision: D98942362
abeakkas
force-pushed
the
export-D98942362
branch
2 times, most recently
from
70a6715 to
23c366d
Compare
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
Apr 2, 2026
…is false. (pytorch#18616) Summary: When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count. Reviewed By: DrJessop Differential Revision: D98942362
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
Apr 3, 2026
…is false. (pytorch#18616) Summary: When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count. Reviewed By: DrJessop Differential Revision: D98942362
abeakkas
force-pushed
the
export-D98942362
branch
from
23c366d to
bb1ac14
Compare
abeakkas
added a commit
to abeakkas/executorch
that referenced
this pull request
Apr 3, 2026
…is false. (pytorch#18616) Summary: When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count. Reviewed By: DrJessop Differential Revision: D98942362
abeakkas
force-pushed
the
export-D98942362
branch
from
bb1ac14 to
ff998ba
Compare
…is false. (pytorch#18616) Summary: When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count. Reviewed By: DrJessop Differential Revision: D98942362
abeakkas
force-pushed
the
export-D98942362
branch
from
ff998ba to
62b4531
Compare
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Apr 14, 2026
…is false. (pytorch#18616) Differential Revision: D98942362 Pull Request resolved: pytorch#18616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When count_include_pad was false, the divisor was always set to the non-padded element count, silently ignoring any divisor_override. Now divisor_override is passed into avg_pool2d_nchw and takes priority over both count_include_pad and the per-element count.
Reviewed By: DrJessop
Differential Revision: D98942362