Skip to content

Zephyr: Bump cmake dependency#18633

Merged
zingo merged 1 commit intopytorch:mainfrom
Christoffer-JL:cjoh_temp
Apr 1, 2026
Merged

Zephyr: Bump cmake dependency#18633
zingo merged 1 commit intopytorch:mainfrom
Christoffer-JL:cjoh_temp

Conversation

@Christoffer-JL
Copy link
Copy Markdown
Collaborator

@Christoffer-JL Christoffer-JL commented Apr 1, 2026

Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com>
Change-Id: If06dc8f11a573ffd3f6a438a7b63223720c12039
@Christoffer-JL Christoffer-JL added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Apr 1, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18633

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 1 Awaiting Approval, 145 Pending

As of commit 6394d75 with merge base ad235f8 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2026
@zingo zingo merged commit 37ea3ff into pytorch:main Apr 1, 2026
415 of 424 checks passed
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 1, 2026

@pytorchbot cherry-pick --onto release/1.2 -c {docs}

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 1, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: '{docs}' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 1, 2026

@pytorchbot cherry-pick --onto release/1.2 -c docs

@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 1, 2026

Nice to have on 1.2 but not super important, the suggested cmake version was removed as pip packages today so it can't be installed, but if a user tries it they will discover and probably install another cmake version.

pytorchbot pushed a commit that referenced this pull request Apr 1, 2026
Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com>
(cherry picked from commit 37ea3ff)
@pytorchbot
Copy link
Copy Markdown
Collaborator

Cherry picking #18633

The cherry pick PR is at #18634 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@manuelcandales
Copy link
Copy Markdown
Contributor

Nice to have on 1.2 but not super important, the suggested cmake version was removed as pip packages today so it can't be installed, but if a user tries it they will discover and probably install another cmake version.

Yeah, I was going to land #18632 and cherry-pick, but you beat me to it :)

Jiseong-oh pushed a commit to Jiseong-oh/executorch that referenced this pull request Apr 2, 2026
Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com>
Jiseong-oh pushed a commit that referenced this pull request Apr 2, 2026
Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com>
Jiseong-oh pushed a commit that referenced this pull request Apr 7, 2026
Updated the cmake dependecy v3.29 -> v<4.0.0,
this is due to PyPI not finding 3.29 anymore

Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants