Skip to content

Fix Cadence test failures (#18655)#18655

Merged
meta-codesync[bot] merged 1 commit intomainfrom
cadence-test-fixes
Apr 2, 2026
Merged

Fix Cadence test failures (#18655)#18655
meta-codesync[bot] merged 1 commit intomainfrom
cadence-test-fixes

Conversation

@aliafzal
Copy link
Copy Markdown
Contributor

@aliafzal aliafzal commented Apr 1, 2026

Summary:

  • Fix test_pass_filter.py: use clear()+update() instead of rebinding
    ALL_CADENCE_PASSES in tearDown to keep the same dict object reference
  • Fix test_g3_ops.py: remove obsolete run_and_compare flag
  • Thread file_name through export_and_run_model → runtime.run_and_compare
    → runtime.run → Executor so the runner loads the correct .bpte file
  • Fix facto_util.py: import random_manager instead of seeded_random_manager
    to match the current FACTO submodule

Test Plan:
OSS:

  1. python -m pytest backends/cadence/aot/tests/ -v — 488 passed
  2. `python -m pytest examples/cadence/operators/test_g3_ops.py

Reviewed By: zonglinpeng

Differential Revision: D99168797

Pulled By: aliafzal

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18655

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 5b756b9 with merge base 3a6314e (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@aliafzal aliafzal requested a review from zonglinpeng April 1, 2026 21:53
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2026
@aliafzal aliafzal requested a review from mcremon-meta April 1, 2026 21:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@aliafzal aliafzal added the module: cadence Issues related to the Cadence/Xtensa backend label Apr 1, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 1, 2026

@aliafzal has imported this pull request. If you are a Meta employee, you can view this in D99168797.

@meta-codesync meta-codesync bot changed the title Fix Cadence test failures Fix Cadence test failures (#18655) Apr 2, 2026
@aliafzal aliafzal force-pushed the cadence-test-fixes branch from 5ef8120 to 9b7a505 Compare April 2, 2026 04:26
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 2, 2026

@aliafzal has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99168797.

- Fix test_pass_filter.py: use clear()+update() instead of rebinding
  ALL_CADENCE_PASSES in tearDown to keep the same dict object reference
- Fix test_g3_ops.py: remove obsolete run_and_compare flag
- Thread file_name through export_and_run_model → runtime.run_and_compare
  → runtime.run → Executor so the runner loads the correct .bpte file
- Fix facto_util.py: import random_manager instead of seeded_random_manager
  to match the current FACTO submodule
@aliafzal aliafzal force-pushed the cadence-test-fixes branch from 10250e0 to 5b756b9 Compare April 2, 2026 08:40
@meta-codesync meta-codesync bot merged commit 22780b5 into main Apr 2, 2026
165 of 167 checks passed
@meta-codesync meta-codesync bot deleted the cadence-test-fixes branch April 2, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: cadence Issues related to the Cadence/Xtensa backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants