Validate MoveCall

[lucylq]

Summary

Check MoveCall indices are within range (0 <= index < n_values_)

Use a macro to wrap the calls in MoveCall, JumpFalseCall, FreeCall

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18658

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 4a49d17 with merge base c39a0ff ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / windows / windows-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• pull / unittest-editable / windows / windows-job (gh) (trunk failure)
  ##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[Copilot]

Pull request overview

Adds load-time validation for FlatBuffer instruction value indices and centralizes the bounds-check logic, preventing out-of-range access during execution.

Changes:

• Introduces ET_CHECK_VALID_VALUE_INDEX macro to validate instruction value indices against n_value_.
• Applies the validation to JumpFalseCall, MoveCall (both move_from/move_to), and FreeCall.
• Changes the default instruction-args handler to log and fail fast on invalid instruction argument types.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The log message doesn’t include enough context to diagnose which instruction caused the failure (e.g., instr_idx and/or the chain index i). Including those identifiers in the error log materially improves debuggability for malformed/corrupt programs.

Suggested change

	ET_LOG(Error, "Invalid instruction type %hhu", static_cast<uint8_t>(instruction->instr_args_type()));
	ET_LOG(
	Error,
	"Invalid instruction type %hhu at chain index %" ET_PRIsize_t
	" instruction index %" ET_PRIsize_t,
	static_cast<uint8_t>(instruction->instr_args_type()),
	i,
	instr_idx);

[JacobSzwejbka]

Looks good but with this general class of error checking should we be centralizing it at program load rather then method init?

[lucylq]

Looks good but with this general class of error checking should we be centralizing it at program load rather then method init?

I feel like we might need a layered approach. The EValues are parsed at method load time, so it makes sense to check index validity of Free/JumpFalse/Move instructions here ..