Cadence HiFi: Fix build errors for ResNet-18 and Emformer RNNT Encoder#18659
Merged
rascani merged 1 commit intopytorch:mainfrom Apr 2, 2026
Merged
Cadence HiFi: Fix build errors for ResNet-18 and Emformer RNNT Encoder#18659rascani merged 1 commit intopytorch:mainfrom
rascani merged 1 commit intopytorch:mainfrom
Conversation
Fix several HiFi build issues preventing ResNet-18 and Emformer RNNT Encoder from compiling and running on the Xtensa toolchain. functions_hifi.yaml: - Add quantized_max_pool2d_nchw op (NCHW variant was missing, only NHWC was registered). Uses generic fallback kernel. - Add native_layer_norm op (needed by Emformer RNNT Encoder). Uses portable kernel. - Fix double native:: namespace on quantized_conv1d_ncl and quantized_conv1d_nlc kernel names — codegen adds the native:: namespace automatically, so having it in the yaml produced impl::HiFi::native::native:: which failed to link. CMakeLists.txt: - Add op_quantized_max_pool2d_nhwc.cpp to custom_ops sources (file existed but was not compiled) - Add generic conv1d fallback sources (op_quantized_conv1d_ncl.cpp, op_quantized_conv1d_nlc.cpp) that HiFi conv1d operators call - Add generic op_quantized_max_pool2d.cpp for NCHW fallback - Add portable op_native_layer_norm.cpp and normalization_ops_util.cpp install_requirements.sh: - Update nnlib-hifi4 SHA to 64d73d72 which adds xa_nn_elm_add_broadcast_4D_f32xf32_f32 (float broadcast add kernel used by op_add.cpp) Authored with Claude.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18659
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit d5c7fb6 with merge base 6bd9bca ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
mcremon-meta
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several HiFi build issues preventing ResNet-18 and Emformer RNNT Encoder from compiling and running on the Xtensa toolchain.
Fixes #18181
functions_hifi.yaml:
CMakeLists.txt:
install_requirements.sh:
Authored with Claude.
Test Plan