Skip to content

Fix QNN is_nan bool tensor subtraction error#18660

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Gasoonjia:export-D99049483
Apr 2, 2026
Merged

Fix QNN is_nan bool tensor subtraction error#18660
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Gasoonjia:export-D99049483

Conversation

@Gasoonjia
Copy link
Copy Markdown
Contributor

Summary:
The QNN delegate simulator test for is_nan fails because _assert_outputs_equal_recipe
uses model - ref to compute differences, but is_nan returns bool tensors and PyTorch
no longer allows subtraction on bool tensors.

Fix: Handle bool tensors separately using torch.equal() and XOR (^) for mismatch
reporting instead of subtraction.

Differential Revision: D99049483

Summary:
The QNN delegate simulator test for is_nan fails because _assert_outputs_equal_recipe
uses model - ref to compute differences, but is_nan returns bool tensors and PyTorch
no longer allows subtraction on bool tensors.

Fix: Handle bool tensors separately using torch.equal() and XOR (^) for mismatch
reporting instead of subtraction.

Differential Revision: D99049483
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18660

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit eb60f22 with merge base c39a0ff (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 1, 2026

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99049483.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit 7bbff19 into pytorch:main Apr 2, 2026
161 of 174 checks passed
Jiseong-oh pushed a commit to Jiseong-oh/executorch that referenced this pull request Apr 2, 2026
Differential Revision: D99049483

Pull Request resolved: pytorch#18660
Jiseong-oh pushed a commit that referenced this pull request Apr 2, 2026
Differential Revision: D99049483

Pull Request resolved: #18660
Jiseong-oh pushed a commit that referenced this pull request Apr 7, 2026
Differential Revision: D99049483

Pull Request resolved: #18660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants