Skip to content

2/x: Introduce new ETCoreMLModelCache that adheres to cache protocol (#18682)#18682

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
metascroy:export-D91183831
Apr 4, 2026
Merged

2/x: Introduce new ETCoreMLModelCache that adheres to cache protocol (#18682)#18682
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
metascroy:export-D91183831

Conversation

@metascroy
Copy link
Copy Markdown
Contributor

@metascroy metascroy commented Apr 3, 2026

Summary:

This is diff 2/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md

[ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ]

The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/h4vincwz for what this diff does.

Reviewed By: digantdesai

Differential Revision: D91183831

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 3, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18682

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Cancelled Jobs, 27 Unrelated Failures

As of commit 63b8599 with merge base 28f3cf3 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 3, 2026

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91183831.

Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title 2/x: Introduce new ETCoreMLModelCache that adheres to cache protocol 2/x: Introduce new ETCoreMLModelCache that adheres to cache protocol (#18682) Apr 3, 2026
metascroy added a commit to metascroy/executorch that referenced this pull request Apr 3, 2026
…ytorch#18682)

Summary:

This is diff 2/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md

[ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ]

The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/h4vincwz for what this diff does.

Reviewed By: digantdesai

Differential Revision: D91183831
…ytorch#18682)

Summary:

This is diff 2/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md

[ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ]

The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/h4vincwz for what this diff does.

Reviewed By: digantdesai

Differential Revision: D91183831
@meta-codesync meta-codesync bot merged commit 6020c29 into pytorch:main Apr 4, 2026
393 of 430 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants