Skip to content

Add supressions to ARM StaticCacheModule#18694

Merged
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:fix-mypy
Apr 3, 2026
Merged

Add supressions to ARM StaticCacheModule#18694
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:fix-mypy

Conversation

@GregoryComer
Copy link
Copy Markdown
Member

@GregoryComer GregoryComer commented Apr 3, 2026

Summary

Transformers 5.5 release changed one of the cache types to become a union. Not all union variants have .key and .value, so mypy complains. The code is sound, so just suppress the error since we know what the actual cache type is.

Test plan

Verified lint passes locally and in CI.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 3, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18694

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer marked this pull request as ready for review April 3, 2026 21:16
@GregoryComer GregoryComer requested a review from Gasoonjia April 3, 2026 21:17
@GregoryComer GregoryComer merged commit 15b268f into pytorch:main Apr 3, 2026
151 of 153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants