Skip to content

[ET-VK] Fix force_fp16 texture bias being silently rejected for CONTIGUOUS_ANY ops #18770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 2 commits into from
Apr 8, 2026
Merged

[ET-VK] Fix force_fp16 texture bias being silently rejected for CONTIGUOUS_ANY ops #18770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1640f
[ET-VK] Fix force_fp16 texture bias being silently rejected for CONTI…
Apr 8, 2026
f8c5861
Update on "[ET-VK] Fix force_fp16 texture bias being silently rejecte…
Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions backends/vulkan/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,14 +1511,19 @@ def try_constrain_with_arg_repset(
if not arg_current_repset.any_in_common(source_repset):
return False

# Compute the narrowed repset (intersection of current arg and source).
narrowed = arg_current_repset.make_intersect(source_repset)

if self.sync_primary_io_repr:
if not self.get_out_repset(0).has_compatible_packed_dim_info_set(
source_repset
):
# Check that the narrowed result is compatible with the output.
# Using the intersection rather than the raw source_repset avoids
# rejecting valid constraints where the source has extra layouts
# (e.g. ANY_TEXTURE includes HP/CP) that don't exist in the output
# but also don't appear in the intersection.
if not self.get_out_repset(0).has_compatible_packed_dim_info_set(narrowed):
return False

# If this point is reached, then it is possible to constrain
narrowed = arg_current_repset.make_intersect(source_repset)
self.args_repset_list[arg_i] = narrowed

# Propagate to other synced args via packed-dim compatibility
Expand Down
Loading