Arm backend: Handle conv qparams from non-fused clamp#18778
Merged
bdemirb merged 2 commits intopytorch:mainfrom Apr 9, 2026
Merged
Arm backend: Handle conv qparams from non-fused clamp#18778bdemirb merged 2 commits intopytorch:mainfrom
bdemirb merged 2 commits intopytorch:mainfrom
Conversation
The bug was caused by a pass-pipeline mismatch in the Arm quantized lowering flow. For a delegated conv -> relu/clamp -> cat branch under TOSA-1.0+INT+FP, the activation can remain unfused when its output quantization is non-fuseable (zp != qmin). In that case, quantization annotation and qparam folding legitimately leave input_qparams on the conv and output_qparams on the surviving clamp, but RewriteConvPass incorrectly assumed every quantized conv would always own local output_qparams and crashed when inserting the output rescale. The fix makes RewriteConvPass resolve the conv's effective output qparams from a following quantized clamp when needed, which matches the real quantized output domain of the unfused branch. The patch also fixes synthetic bias creation for biasless quantized convs by detecting quantization from input_qparams instead of relying on local output_qparams. Signed-off-by: Baris Demir <baris.demir@arm.com> Change-Id: I373e9eca8490148bc90dee487a2963612a494d8b
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18778
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Pending, 6 Unrelated FailuresAs of commit e184ca7 with merge base c72d176 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label "partner: arm" |
Collaborator
Author
|
@pytorchbot label "release notes: arm" |
Collaborator
|
Zephyr fails due to that the cmake 3.29 pip package was removed from pip :( e.g. this line: |
zingo
approved these changes
Apr 8, 2026
Collaborator
zingo
left a comment
There was a problem hiding this comment.
OK to merge is tests pass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell