Remove un-used copy from building dockers#18868
Conversation
The removed copy seems to be stale, it is never used. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I5d6e6a5f18a1fd69b1b38954bcbe4b73d887ea15
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18868
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 10 Cancelled Jobs, 3 Unrelated FailuresAs of commit afdacf2 with merge base 2eaa16c ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| # Copy requirements-lintrunner.txt from root to here | ||
| cp ../../requirements-lintrunner.txt ./ | ||
|
|
||
| # Copy arm setup script from root to here |
There was a problem hiding this comment.
IIUC, and this was a while ago, this was needed to make sure we get the latest files in the docker build for the PR we are testing.
There was a problem hiding this comment.
You might be right, but I am not able to find any evidence of this being used. If you look at the PR that introduced it, https://github.com/pytorch/executorch/pull/1111/changes, ./arm is copied to the docker's /opt/arm to then run setup.sh. This code does not exist anymore. The only thing the ARM_SDK arg does is run install_arm.sh, which just installs some drivers.
There was a problem hiding this comment.
Now when all deps a pip packages (even tosa-tools and MLSDK) we can and probably should clean out all stuff from the docker and use a plain one.
As a later improvements we can just prerun some pip installs to speed things up if we want.
e.g. I propose to merge this, cleanup old strange stuff and then maybe rethink the docker acceleration setup so we get a clean one. Would that be ok @digantdesai ?
The removed copy seems to be stale, it is never used.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell