Skip to content

Arm backend: Eliminate dead shape ops#18902

Merged
oscarandersson8218 merged 1 commit intopytorch:mainfrom
oscarandersson8218:remove_unused_shape_ops
Apr 15, 2026
Merged

Arm backend: Eliminate dead shape ops#18902
oscarandersson8218 merged 1 commit intopytorch:mainfrom
oscarandersson8218:remove_unused_shape_ops

Conversation

@oscarandersson8218
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 commented Apr 15, 2026

Shape ops get their dim_order from their users. If a shape-op does not have any users, it will therefore not get a dim_order and crash during serialization. To avoid this, we can simply delete any unused shape op from the graph before serialization.

cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

Shape ops get their dim_order from their users. If a shape-op does not
have any users, it will therefore not get a dim_order and crash during
serialization. To avoid this, we can simply delete any unused shape op
from the graph before serialzation.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I06cfb68056294e6dbf1d69129645130d4fb8c952
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18902

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 3 Unrelated Failures

As of commit 9430708 with merge base 87e65ac (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Apr 15, 2026
@oscarandersson8218
Copy link
Copy Markdown
Collaborator Author

Unrelated failures.

@oscarandersson8218 oscarandersson8218 merged commit b5cf3c3 into pytorch:main Apr 15, 2026
414 of 431 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants