Skip to content

Fix 'occured' -> 'occurred' typos in backends and exir tracer#18905

Merged
kirklandsign merged 1 commit intopytorch:mainfrom
SAY-5:fix-occured-typos-backends-exir
Apr 16, 2026
Merged

Fix 'occured' -> 'occurred' typos in backends and exir tracer#18905
kirklandsign merged 1 commit intopytorch:mainfrom
SAY-5:fix-occured-typos-backends-exir

Conversation

@SAY-5
Copy link
Copy Markdown
Contributor

@SAY-5 SAY-5 commented Apr 15, 2026

Nine error messages used the misspelled occured:

  • backends/apple/mps/runtime/MPSDevice.mm:141 — additionally had a duplicated occured occured (An error occured occured while compiling library %d).
  • backends/cadence/hifi/operators/op_quantized_matmul_out.cpp × 3
  • backends/cadence/hifi/operators/op_quantized_matmul_asym8uxasym8u_asym8u_out.cpp × 3
  • backends/cadence/hifi/operators/op_quantized_matmul_asym8sxasym8s_asym8s_out.cpp × 3
  • exir/tracer.py — torchdynamo internal-error format string

All ET_CHECK_MSG and printf-style messages reach end users in build / runtime error output, and the dynamo tracer message is logged on every dynamo trace failure. Python ast.parse clean for the touched tracer.py; .cpp/.mm changes are string-literal-only with no logic touched.

Eight runtime error messages and one Python format string used the
misspelled 'occured':

  * backends/apple/mps/runtime/MPSDevice.mm — additionally had a
    duplicated 'occured occured' from a stutter typo.
  * backends/cadence/hifi/operators/op_quantized_matmul_out.cpp (3)
  * backends/cadence/hifi/operators/op_quantized_matmul_asym8uxasym8u_asym8u_out.cpp (3)
  * backends/cadence/hifi/operators/op_quantized_matmul_asym8sxasym8s_asym8s_out.cpp (3)
  * exir/tracer.py — torchdynamo internal-error format string surfaced
    on every dynamo trace failure.

All ET_CHECK_MSG and printf-style messages reach end users in build
and runtime error output. Python ast.parse stays clean for tracer.py;
.cpp/.mm changes are string-literal-only with no logic changes.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18905

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 521361e with merge base 75fe8e9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SAY-5
Copy link
Copy Markdown
Contributor Author

SAY-5 commented Apr 15, 2026

/release-notes none

This is a typo-only fix to error message strings — no user-facing behaviour change.

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

thanks

@SAY-5
Copy link
Copy Markdown
Contributor Author

SAY-5 commented Apr 16, 2026

@JacobSzwejbka thanks for the review! Just flagging this is ready to merge (CI green, approved). Would you mind landing it when you get a moment?

@kirklandsign
Copy link
Copy Markdown
Contributor

@claude review

@claude
Copy link
Copy Markdown

claude Bot commented Apr 16, 2026

Claude finished @kirklandsign's task in 34s —— View job


Review of PR #18905

  • Read PR diff and verify changes
  • Check each file for correctness
  • Confirm no remaining instances of the typo in the codebase
  • Post review feedback

LGTM. All changes are string-literal-only typo fixes with no logic changes.

Verified:

  • backends/apple/mps/runtime/MPSDevice.mm:141 — Fixes both the misspelling and the duplicated word ("occured occured""occurred"). Good catch on the double word.
  • backends/cadence/hifi/operators/ (3 files, 11 occurrences) — Straightforward "occured""occurred" in ET_CHECK_MSG strings.
  • exir/tracer.py:703 — Same fix in the dynamo InternalError message.

I confirmed via grep that no instances of occured remain anywhere in the repository after this change.

No issues found. This is ready to land.

@kirklandsign kirklandsign merged commit 3180927 into pytorch:main Apr 16, 2026
167 of 172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants