Skip to content

Arm backend: Add TOSA AVG_POOL2D op#18972

Merged
AdrianLundell merged 1 commit intopytorch:mainfrom
SaoirseARM:toupstream/avg_pool
Apr 17, 2026
Merged

Arm backend: Add TOSA AVG_POOL2D op#18972
AdrianLundell merged 1 commit intopytorch:mainfrom
SaoirseARM:toupstream/avg_pool

Conversation

@SaoirseARM
Copy link
Copy Markdown
Collaborator

@SaoirseARM SaoirseARM commented Apr 17, 2026

Summary

Adds new TOSA dialect op for AVG_POOL2D. aten.AvgPool2d nodes are replaced by tosa.AVG_POOL2D in RewriteAvgPool2dPass. op_avg_pool2d node visitor is replaced by a simpler node vistior for tosa.avg_pool2d.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Adds new TOSA dialect op for AVG_POOL2D. aten.AvgPool2d nodes are
replaced by tosa.AVG_POOL2D in RewriteAvgPool2dPass. op_avg_pool2d
node visitor is replaced by a simpler node vistior for tosa.avg_pool2d.

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18972

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 1 Pending, 2 Unrelated Failures

As of commit 5979165 with merge base 9d72936 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2026
@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label Apr 17, 2026
@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't think it needs any BUCK changes.

@AdrianLundell AdrianLundell merged commit 1154d34 into pytorch:main Apr 17, 2026
417 of 433 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants