Qualcomm AI Engine Direct - Adding QNN backend support for atan2 core ATen ops#19051
Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom Apr 29, 2026
Merged
Qualcomm AI Engine Direct - Adding QNN backend support for atan2 core ATen ops#19051abhinaykukkadapu merged 1 commit intopytorch:mainfrom
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19051
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit 72a42b3 with merge base 069a793 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "release notes: qualcomm" |
abhinaykukkadapu
approved these changes
Apr 22, 2026
Contributor
Author
|
@abhinaykukkadapu Hi, is there anything you wanted me to modify with this PR? |
Contributor
Ohhh i forgot to merge this, as i was waiting for CI results at that time, will merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for the
atan2ATen op by a decomposition pass using the identity:Note that the op
atan2.outis also added as a target, even though that op is converted toatan2.defaultbytorch.export. The decomposition would still work in case the conversion was missed somehow.Test plan