Skip to content

Merge back to back slices on the same dim#19128

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
DrJessop:export-D102425537
Apr 25, 2026
Merged

Merge back to back slices on the same dim#19128
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
DrJessop:export-D102425537

Conversation

@DrJessop
Copy link
Copy Markdown
Contributor

Summary:
If we have back to back slices on the same dimension, we can remove the top slice and just perform the second one. RemoveOrReplacePassInterface will handle a whole cascade if it exists.

Handles negative start/end indices by canonicalizing them, and negative dims by normalizing against ndim. Clamps the merged end to the parent's end to handle child ranges that exceed the parent output size.

Differential Revision: D102425537

Summary:
If we have back to back slices on the same dimension, we can remove the top slice and just perform the second one. RemoveOrReplacePassInterface will handle a whole cascade if it exists.

Handles negative start/end indices by canonicalizing them, and negative dims by normalizing against ndim. Clamps the merged end to the parent's end to handle child ranges that exceed the parent output size.

Differential Revision: D102425537
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 25, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19128

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Cancelled Jobs, 2 Unrelated Failures

As of commit 0204b9e with merge base 2330652 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 25, 2026

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102425537.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit c1d482e into pytorch:main Apr 25, 2026
174 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants