Arm backend: Fix meta propagation in some call passes#19154
Merged
Erik-Lundell merged 2 commits intopytorch:mainfrom Apr 27, 2026
Merged
Arm backend: Fix meta propagation in some call passes#19154Erik-Lundell merged 2 commits intopytorch:mainfrom
Erik-Lundell merged 2 commits intopytorch:mainfrom
Conversation
When a call pass creates a node, it won't get a meta["val"] field until the graph is re-traced, unless explicitly set. This is not usually a problem, but if a pass needs meta["val"] from an argument, and an op is chained multiple times, the pass will crash if the meta is not there/incorrectly set. Fix a couple of passes where the field was missing, or using the incorrect value. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I9b93e29a66bf9cce1fe0a371546020c2eb0828c2
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19154
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 6 New Failures, 2 Pending, 4 Unrelated FailuresAs of commit e1a191c with merge base d7f8718 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a call pass creates a node, it won't get a meta["val"] field until the graph is re-traced, unless explicitly set.
This is not usually a problem, but if a pass needs meta["val"] from an argument, and an op is chained multiple times, the pass will crash if the meta is not there/incorrectly set.
Fix a couple of passes where the field was missing, or using the incorrect value.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell