Skip to content

Arm backend: Fix meta propagation in some call passes#19154

Merged
Erik-Lundell merged 2 commits intopytorch:mainfrom
Erik-Lundell:ops-in-row
Apr 27, 2026
Merged

Arm backend: Fix meta propagation in some call passes#19154
Erik-Lundell merged 2 commits intopytorch:mainfrom
Erik-Lundell:ops-in-row

Conversation

@Erik-Lundell
Copy link
Copy Markdown
Collaborator

@Erik-Lundell Erik-Lundell commented Apr 27, 2026

When a call pass creates a node, it won't get a meta["val"] field until the graph is re-traced, unless explicitly set.

This is not usually a problem, but if a pass needs meta["val"] from an argument, and an op is chained multiple times, the pass will crash if the meta is not there/incorrectly set.

Fix a couple of passes where the field was missing, or using the incorrect value.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

When a call pass creates a node, it won't get a meta["val"] field
until the graph is re-traced, unless explicitly set.

This is not usually a problem, but if a pass needs meta["val"]  from
an argument, and an  op is chained multiple times, the pass will crash
if the meta is not there/incorrectly set.

Fix a couple of passes where the field  was missing, or using the
incorrect value.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I9b93e29a66bf9cce1fe0a371546020c2eb0828c2
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 27, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend and removed release notes: none Do not include this in the release notes labels Apr 27, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19154

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 2 Pending, 4 Unrelated Failures

As of commit e1a191c with merge base d7f8718 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Erik-Lundell Erik-Lundell added the release notes: none Do not include this in the release notes label Apr 27, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@Erik-Lundell Erik-Lundell merged commit 62d8f21 into pytorch:main Apr 27, 2026
427 of 454 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants