Enable stricter type checking for torch/fx#19156
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19156
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit cf5f6f3 with merge base cb4e5ae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102619388. |
There was a problem hiding this comment.
Pull request overview
Enables stricter type checking by adding explicit non-None assertions for torch.fx.Graph.owning_module in Cadence FX fusion utilities.
Changes:
- Added an assertion that
node.graph.owning_moduleis present before reading tensor attributes inget_tensor_arg. - Added an assertion that
conv_node.graph.owning_moduleis present before reading optional bias attributes in_extract_conv_params.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@pytorchbot label "release notes: none" |
Summary: Add torch/fx/** sub-config to pyrefly.toml enabling implicit-any, unannotated-return, and unannotated-parameter checks. Add tabulate to ignore-missing-imports since it is not a strict requirement Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo X-link: pytorch/pytorch#180625 Differential Revision: D102619388 Pulled By: Lucaskabela
225d56f to
cf5f6f3
Compare
Summary:
Add torch/fx/** sub-config to pyrefly.toml enabling implicit-any, unannotated-return, and unannotated-parameter checks. Add tabulate to ignore-missing-imports since it is not a strict requirement
Authored with Claude.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
X-link: pytorch/pytorch#180625
Differential Revision: D102619388
Pulled By: Lucaskabela