Skip to content

Enable stricter type checking for torch/fx#19156

Merged
JacobSzwejbka merged 1 commit intopytorch:mainfrom
Lucaskabela:export-D102619388
Apr 30, 2026
Merged

Enable stricter type checking for torch/fx#19156
JacobSzwejbka merged 1 commit intopytorch:mainfrom
Lucaskabela:export-D102619388

Conversation

@Lucaskabela
Copy link
Copy Markdown
Contributor

Summary:
Add torch/fx/** sub-config to pyrefly.toml enabling implicit-any, unannotated-return, and unannotated-parameter checks. Add tabulate to ignore-missing-imports since it is not a strict requirement

Authored with Claude.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo

X-link: pytorch/pytorch#180625

Differential Revision: D102619388

Pulled By: Lucaskabela

Copilot AI review requested due to automatic review settings April 27, 2026 15:48
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19156

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit cf5f6f3 with merge base cb4e5ae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 27, 2026

@Lucaskabela has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102619388.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables stricter type checking by adding explicit non-None assertions for torch.fx.Graph.owning_module in Cadence FX fusion utilities.

Changes:

  • Added an assertion that node.graph.owning_module is present before reading tensor attributes in get_tensor_arg.
  • Added an assertion that conv_node.graph.owning_module is present before reading optional bias attributes in _extract_conv_params.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lucaskabela
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Apr 27, 2026
@Lucaskabela
Copy link
Copy Markdown
Contributor Author

@JacobSzwejbka

Summary:
Add torch/fx/** sub-config to pyrefly.toml enabling implicit-any, unannotated-return, and unannotated-parameter checks. Add tabulate to ignore-missing-imports since it is not a strict requirement

Authored with Claude.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo

X-link: pytorch/pytorch#180625

Differential Revision: D102619388

Pulled By: Lucaskabela
@JacobSzwejbka JacobSzwejbka merged commit e089ba4 into pytorch:main Apr 30, 2026
173 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants