Skip to content

NXP Neutron forward fix missing arg#19158

Merged
JacobSzwejbka merged 1 commit intomainfrom
forward-fix-nxp
Apr 27, 2026
Merged

NXP Neutron forward fix missing arg#19158
JacobSzwejbka merged 1 commit intomainfrom
forward-fix-nxp

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

Internal sdk version needs to be bumped I think. To get around the failing CI for now I think we can just gate the flag like this. IIUC it shouldnt regress internal since this flag would be false then anyway.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19158

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ 6 Pending, 2 Unrelated Failures

As of commit 1d7a3b4 with merge base 5252704 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@JacobSzwejbka JacobSzwejbka changed the title forward fix missing arg NXP Neutron forward fix missing arg Apr 27, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless BC fix. Thanks @JacobSzwejbka

@JacobSzwejbka JacobSzwejbka merged commit 2084866 into main Apr 27, 2026
175 of 180 checks passed
@JacobSzwejbka JacobSzwejbka deleted the forward-fix-nxp branch April 27, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants